Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: treat SDXL hires fix like cascade (1024x longest dim) #281

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Conversation

tazlin
Copy link
Member

@tazlin tazlin commented Jul 8, 2024

  • This fixes SDXL requests being coerced into low-resolution first pass images
    • For example, for a 1536x1536 request, before this change the first pass image would be 512x512 instead of the intended 1024x1024
    • In the case of non-square input resolutions, 1024x will be used at the longest dimension, as with our current Stable Cascade 1.0 'hires fix' implementation.

@tazlin tazlin added the release:patch Version _._.x label Jul 8, 2024
@tazlin tazlin requested a review from db0 July 8, 2024 17:19
@tazlin
Copy link
Member Author

tazlin commented Jul 8, 2024

@db0 Assuming this is alright with you, please merge via Merge pull request - do not worry about the tests for now.

@tazlin tazlin merged commit d5c62be into releases Jul 8, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:patch Version _._.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant