fix: allow extra attribs for HordeAPIObject #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
tazlin
commented
Nov 23, 2024
tazlin
commented
- See fix: allow extra attribs for HordeAPIObject #297 for more information.
…th 5 updates (#290) * build(deps-dev): bump the python-packages group across 1 directory with 5 updates Updates the requirements on [mypy](https://github.com/python/mypy), [black](https://github.com/psf/black), [ruff](https://github.com/astral-sh/ruff), [tox](https://github.com/tox-dev/tox) and [pre-commit](https://github.com/pre-commit/pre-commit) to permit the latest version. Updates `mypy` from 1.11.2 to 1.13.0 - [Changelog](https://github.com/python/mypy/blob/master/CHANGELOG.md) - [Commits](python/mypy@v1.11.2...v1.13.0) Updates `black` from 24.8.0 to 24.10.0 - [Release notes](https://github.com/psf/black/releases) - [Changelog](https://github.com/psf/black/blob/main/CHANGES.md) - [Commits](psf/black@24.8.0...24.10.0) Updates `ruff` from 0.6.8 to 0.7.2 - [Release notes](https://github.com/astral-sh/ruff/releases) - [Changelog](https://github.com/astral-sh/ruff/blob/main/CHANGELOG.md) - [Commits](astral-sh/ruff@0.6.8...0.7.2) Updates `tox` to 4.23.2 - [Release notes](https://github.com/tox-dev/tox/releases) - [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst) - [Commits](tox-dev/tox@4.20.0...4.23.2) Updates `pre-commit` to 4.0.1 - [Release notes](https://github.com/pre-commit/pre-commit/releases) - [Changelog](https://github.com/pre-commit/pre-commit/blob/main/CHANGELOG.md) - [Commits](pre-commit/pre-commit@v3.8.0...v4.0.1) --- updated-dependencies: - dependency-name: mypy dependency-type: direct:development update-type: version-update:semver-minor dependency-group: python-packages - dependency-name: black dependency-type: direct:development update-type: version-update:semver-minor dependency-group: python-packages - dependency-name: ruff dependency-type: direct:development update-type: version-update:semver-minor dependency-group: python-packages - dependency-name: tox dependency-type: direct:development dependency-group: python-packages - dependency-name: pre-commit dependency-type: direct:development dependency-group: python-packages ... Signed-off-by: dependabot[bot] <[email protected]> * chore/deps: update pre-commit hook versions --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: tazlin <[email protected]>
This makes this class consistent with `HordeAPIDataObject` and my intentions. Practically speaking, for forward compatibility and in a live situation we want to allow additional information to propagate from the API to an end user where possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.