Keep worker IP addresses and user contact info private when public_worker settings allow unprivileged requests to browse a user's workers #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the user wants to make their contact info public, they can include it in the info field, but the docs explicitly say that the IP address is privileged, and don't mention it being made available based on public_worker field.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the docs explicitly say that the IP address is privileged, and don't mention it being made available based on public_worker field.
If the user wants to make their contact info public, they can include it in the info field
This issue was noticed by Sidorok here
This fix is untested (I'm doing this from my tablet)