Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix conflicting Doctrine querybuilder support with PhpStorm implementation #2334

Open
Haehnchen opened this issue Apr 4, 2024 · 0 comments
Open

Fix conflicting Doctrine querybuilder support with PhpStorm implementation #2334

Haehnchen opened this issue Apr 4, 2024 · 0 comments

Comments

@Haehnchen
Copy link
Owner

Haehnchen commented Apr 4, 2024 •
edited
Loading

https://blog.jetbrains.com/phpstorm/2023/12/phpstorm-2023-3-is-now-available/#symfony-support introduced support for Doctrine querybuilder.

Its not including resolving Entity scope. Only if there are a "from" keyword given. That it not usable for common Symfony projects

image

image

Since then this breaks some implementations here:

  • parameters provide language injection (but only some), which need special catching.
  • some quick workaround are already implemented, needs rethinking
  • "some feature" are lost on injected parameters and need to be reimplement
@Haehnchen Haehnchen changed the title Fix conflicting on Doctrine querybuilder with PhpStorm implementation Fix conflicting Doctrine querybuilder support with PhpStorm implementation Apr 4, 2024
Haehnchen added a commit that referenced this issue Apr 14, 2024
@Haehnchen
#2334 optimize prefix matcher for Doctrine querybuilder parameter, to…
ea3f307 
… reduce conflicting PhpStorm implementation
Haehnchen added a commit that referenced this issue Apr 14, 2024
@Haehnchen
#2334 optimize prefix matcher for Doctrine querybuilder parameter, to…
009dc56 
… reduce conflicting PhpStorm implementation
Haehnchen added a commit that referenced this issue Apr 14, 2024
@Haehnchen
#2334 optimize prefix matcher for Doctrine querybuilder parameter, to…
2e5a272 
… reduce conflicting PhpStorm implementation
Haehnchen added a commit that referenced this issue Apr 14, 2024
@Haehnchen
#2334 optimize prefix matcher for Doctrine querybuilder parameter, to…
f707601 
… reduce conflicting PhpStorm implementation
Haehnchen added a commit that referenced this issue Apr 14, 2024
@Haehnchen
#2334 optimize prefix matcher for Doctrine querybuilder parameter, to…
5073618 
… reduce conflicting PhpStorm implementation
Haehnchen added a commit that referenced this issue Apr 14, 2024
@Haehnchen
Merge pull request #2349 from Haehnchen/feature/2334-qb-prefix
7a38bc3 
#2334 optimize prefix matcher for Doctrine querybuilder parameter, to reduce conflicting PhpStorm implementation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Haehnchen