Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate handle_special_dialog_text() #550

Open
gheskett opened this issue Dec 8, 2022 · 0 comments
Open

Deprecate handle_special_dialog_text() #550

gheskett opened this issue Dec 8, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@gheskett
Copy link
Collaborator

gheskett commented Dec 8, 2022

None of the hardcoded dialog entries in this function should be affecting music sequences or SFX, when they could all be easily triggered in object behaviors or part of the dialog selection code instead. Additionally, remove puzzle jingle support for custom dialogs and instead trigger that to play as part of the cap switch behaviors instead. This should not be started until ASCII is merged.

@gheskett gheskett added the enhancement New feature or request label Dec 8, 2022
@gheskett gheskett added this to the 2.1 milestone Dec 8, 2022
@gheskett gheskett self-assigned this Dec 8, 2022
@gheskett gheskett modified the milestones: 2.1, 3.0 Mar 6, 2023
@gheskett gheskett modified the milestones: 3.0, 2.2 Sep 27, 2023
@gheskett gheskett modified the milestones: 2.2, 3.0 Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: To do
Development

No branches or pull requests

1 participant