Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more fields that make their way down to the note and layer structs #498

Open
gheskett opened this issue Sep 28, 2022 · 0 comments
Open

Add more fields that make their way down to the note and layer structs #498

gheskett opened this issue Sep 28, 2022 · 0 comments
Assignees
@gheskett
Labels
enhancement New feature or request low priority Non-urgent issue or feature / low priority
Milestone
3.0

Comments

@gheskett
Copy link
Collaborator

  • Instrument ID (exists in non-US versions already) [Type: u8]
  • Sequence player ID [Type: u8]
  • Sequence channel index [Type: u8]
  • Sound effect channel table index (default to 0xFF if not applicable) [Type: u8]

These four fields would make identifying specific sound effects / instruments substantially easier, along with making hardcoded low-level sound exceptions easier to implement across the board.
@gheskett gheskett added enhancement New feature or request low priority Non-urgent issue or feature / low priority labels Sep 28, 2022
@gheskett gheskett added this to the 2.1 milestone Sep 28, 2022
@gheskett gheskett self-assigned this Sep 28, 2022
@gheskett gheskett modified the milestones: 2.1, 3.0 Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gheskett gheskett

Labels
enhancement New feature or request low priority Non-urgent issue or feature / low priority
Projects
3.0 (Major Feature Update)
Status: To do
Milestone
3.0
Development

No branches or pull requests
1 participant
@gheskett