Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look For Ways to Increase SM64's Pitch Limit by 1 Or 2 Octaves #399

Open
gheskett opened this issue May 3, 2022 · 2 comments
Open

Look For Ways to Increase SM64's Pitch Limit by 1 Or 2 Octaves #399

gheskett opened this issue May 3, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@gheskett
Copy link
Collaborator

gheskett commented May 3, 2022

90% sure this is possible within reason from what I've read in the code, and hopefully won't come with any major performance implications as long as it isn't totally abused.

Still TODO: Verify this would also work properly with reverb buffers/downsampling. Also confirm the RSP doesn't need extra space to deal with it, and look into potentially increasing the max number of RSP commands per note to compensate.

@gheskett gheskett added the enhancement New feature or request label May 3, 2022
@gheskett gheskett added this to the 2.2 milestone May 3, 2022
@gheskett gheskett self-assigned this May 3, 2022
@gheskett gheskett changed the title Look For Ways to Increase SM64s Pitch Limit by 1 Or 2 Octaves Look For Ways to Increase SM64's Pitch Limit by 1 Or 2 Octaves May 3, 2022
@FazanaJ
Copy link
Collaborator

FazanaJ commented May 3, 2022

if the pitch limit can be raised, you can safely set the audio frequency to 22000Hz and not lose any audio quality, but also get a speedup

@gheskett
Copy link
Collaborator Author

gheskett commented May 3, 2022

22000Hz is hella quality loss, did you mean audio accuracy?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: To do
Development

No branches or pull requests

2 participants