Allow automatic shift exchanges #57
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added configuration for vagrant box * Updated documentation for new build process * Add bootstrap to setup process * Add virtualbox reference Co-authored-by: Rui Oliveira <rpoliveira02@gmailcom>
* Adapt exchanges table to new format * Tweak style of exchanges table
* Updated documentation for new build process * added function to support the new exchanges * added a way to create autoExchanges and perform them without dataraces * removed issue of non deleted temporary enrollment * removed some errors * problems solved * front-end for the automatic exchange * Delete NoExchangesCanBeDone.php * Update ExchangeController.php * Update Enrollment.php * Update readme.md * Update Enrollment.php * Update Enrollment.php * Update Enrollment.php * Update Enrollment.php * Update Enrollment.php * Update app/Http/Controllers/EnrollmentAutomaticExchangeController.php Co-authored-by: Rui Oliveira <[email protected]> * Update readme.md Co-authored-by: Rui Oliveira <[email protected]> * Update resources/assets/js/components/modals/DeleteExchangeModal.vue Co-authored-by: Rui Oliveira <[email protected]> * added to the env the url to the solver Co-authored-by: Rui Oliveira <rpoliveira02@gmailcom> Co-authored-by: Rui Oliveira <[email protected]>
* added a way so that automatic and normal exchanges show in diferent ways in the dashboard * fixed an issue where the shift select component wouldn't show up * npm audith
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12 .
To compute the possible matches between students, this service was used.
A student, when requesting an exchange, can select the shift they would like to move to - the student cannot have a pending exchange request for that course.
When that choice is made, the full set of pending requests for that course is sent to the solver service. Whilst waiting for a response, those rows in the DB are locked as to prevent data races.
The solver returns the set of possible exchanges (which can involve multiple students). Swap then proceeds to change the students' enrollments accordingly, and removing the pending exchanges from the DB.
The only modification to the data model that was made was allowing enrollments to have a null student id. If an exchange is to an enrollment which has a null student, it is treated as an automatic exchange. The same applies for the logging table.
I would like to thank everyone (@lumafepe, @raddrax, @nelsonmestevao) who contributed to this improvement 🙏