Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Valeriya bio workflow group 1 #20

Merged
merged 1 commit into from
Jul 20, 2022
Merged

Valeriya bio workflow group 1 #20

merged 1 commit into from
Jul 20, 2022

Conversation

V-Valkiriya
Copy link
Collaborator

@V-Valkiriya V-Valkiriya commented Jul 20, 2022 •
edited
Loading

Checklists

General Checks

  • the branch is up to date with main/master
  • the code works when pulled and run locally
  • All CI checks pass
  • all conflicts are resolved (if any)
  • PR has a descriptive title
  • PR has appropriate labels and milestones for easy identification
  • PR it is assigned to the owner
  • reviewers are assigned
  • the PR contributes only one focused change
  • It is in the appropriate column in the project board (if necessary)
  • has short and clear description
  • is linked to an issue (if it is related)
  • feedback is addressed (if any and if it is appropriate feedback.)

Markdown

  • the markdown source is formatted
  • spelling and grammar is correct in all text
  • The markdown looks correct when you preview the file
  • all links and images work

@V-Valkiriya V-Valkiriya added the md label Jul 20, 2022
@V-Valkiriya V-Valkiriya self-assigned this Jul 20, 2022
@V-Valkiriya V-Valkiriya added this to the workflow-students-bio milestone Jul 20, 2022
@V-Valkiriya V-Valkiriya linked an issue Jul 20, 2022 that may be closed by this pull request
Valeriya: Group 1, Workflow: week 2 #15
Open
13 tasks
BrianMunene96
BrianMunene96 approved these changes Jul 20, 2022
View reviewed changes
Copy link
Collaborator

@BrianMunene96 BrianMunene96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job finishing your bio file and resolving the lint errors 😊

@BrianMunene96 BrianMunene96 merged commit 64da260 into master Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrianMunene96 BrianMunene96 BrianMunene96 approved these changes

Assignees

@V-Valkiriya V-Valkiriya

Labels
md
Projects
None yet
Milestone
workflow-students-bio
Development

Successfully merging this pull request may close these issues.

Valeriya: Group 1, Workflow: week 2
2 participants
@V-Valkiriya @BrianMunene96