Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review #15

Open
1 of 4 tasks
ThibaultLesuisse opened this issue Nov 20, 2022 · 0 comments
Open
1 of 4 tasks

Review #15

ThibaultLesuisse opened this issue Nov 20, 2022 · 0 comments

Comments

@ThibaultLesuisse
Copy link

  • Deepflat: Behavior seems good: deepFlat contains a jsDoc and use cases. The tests also seem pretty sufficient (you have a lot of them 👍 )
  • Difference: No JSDoc on the exported function but it is in the test file (can you move it to the exported function). Tests are sufficient (again a lot of then 👍 ). But I don't see any Strategy or implementation
  • Intersection: Exercise has not been done
  • SplitObject: No JSDoc on the function but Strategy and Implementation seem good 👍. If you just add a JSDoc on the splitObject function the solution is perfect
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ThibaultLesuisse