New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review #6

Open

ThibaultLesuisse opened this issue Nov 20, 2022 · 1 comment

ThibaultLesuisse commented Nov 20, 2022

I only see two PR's that are merged (@inna9Z & @BrianMunene96).
@BrianMunene96's solution look good! Behaviour is there, Strategy too and Implementation as well! There are also a lot of tests! So good job 👍
@inna9Z Your solution is good as well. Decent Behaviour file that also contains a (simple) strategy. Also nice to avoid side effects by copying the array. The test also cover the most important cases! 👍 Good job

Collaborator

inna9Z commented Nov 20, 2022

@ThibaultLesuisse thank you )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment