Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

volunteer-page #23

Merged
merged 1 commit into from
Aug 11, 2022
Merged

volunteer-page #23

merged 1 commit into from
Aug 11, 2022

Conversation

V-Valkiriya
Copy link
Collaborator

@V-Valkiriya V-Valkiriya commented Aug 11, 2022

General Checks

  • the branch is up to date with main/master
  • the code works when pulled and run locally
  • All CI checks pass
  • all conflicts are resolved (if any)
  • PR has a descriptive title
  • PR has appropriate labels and milestones for easy identification
  • PR it is assigned to the owner
  • reviewers are assigned
  • the PR contributes only one focused change
  • It is in the appropriate column in the project board (if necessary)
  • has short and clear description
  • is linked to an issue (if it is related)
  • feedback is addressed (if any and if it is appropriate feedback.)

Markdown

  • the markdown source is formatted
  • spelling and grammar is correct in all text
  • The markdown looks correct when you preview the file
  • all links and images work

HTML

  • pages besides /index.html are stored in /pages
  • the code is well-formatted
  • the HTML is valid
  • there are no inline styles (example: style='color: red;')
  • there are no <style> tags with CSS, all styles are hrefs
  • there is no inline JavaScript (example: onclick='doSomething()')
  • there are no <script> tags with JS, all JS is in an separate file
  • ids are used for JavaScript only, not for CSS
  • semantic tags are used
  • spelling and grammar is correct in all site content

CSS

  • the code is well-formatted
  • passes all the linting checks

@V-Valkiriya V-Valkiriya added this to the Agile Development milestone Aug 11, 2022
@V-Valkiriya V-Valkiriya self-assigned this Aug 11, 2022
@V-Valkiriya V-Valkiriya merged commit a570e89 into master Aug 11, 2022
This was linked to issues Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Volunteer page Volunteer page
1 participant