Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update psi-ms.obo #351

Merged
merged 16 commits into from
Nov 6, 2024
Merged

Update psi-ms.obo #351

merged 16 commits into from
Nov 6, 2024

Conversation

nithujohn
Copy link
Collaborator

New terms added for software

New terms added for software
@ypriverol
Copy link
Contributor

@nithujohn you have to update your branch because you have conflicts.

@nithujohn
Copy link
Collaborator Author

@ypriverol updated the branch

Copy link
Contributor

@edeutsch edeutsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like Joshua's name was truncated. Also, it would be good to have PMIDs instead of PSI:MS where possible. Perseus should probably be capitalized as a proper name of the tool.

@ypriverol
Copy link
Contributor

@nithujohn you have to update again your branch :(

@nithujohn nithujohn requested review from edeutsch and removed request for edeutsch November 5, 2024 13:56
psi-ms.obo Outdated Show resolved Hide resolved
psi-ms.obo Outdated Show resolved Hide resolved
Copy link
Contributor

@edeutsch edeutsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

31363125 is the paper for pLink 2. If you look at the abstract, you'll see that they put a space between the pLink and 2.

22772728 is the paper for the original pLink

18327264 would be an appropriate PMID for xQuest

@ypriverol
Copy link
Contributor

You are right @edeutsch those are the terms.

@nithujohn
Copy link
Collaborator Author

31363125 is the paper for pLink 2. If you look at the abstract, you'll see that they put a space between the pLink and 2.

22772728 is the paper for the original pLink

18327264 would be an appropriate PMID for xQuest

Made the changes, thanks!

@ypriverol ypriverol added this pull request to the merge queue Nov 6, 2024
Merged via the queue into HUPO-PSI:master with commit b352a94 Nov 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants