-
-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translate content to Dutch #1750
Comments
So the html files don't need to be translated right? Just the files under 2020, 2019 and additional files? |
The core html files DO need to be translated. The chapter HTMLs not shown above (e.g. performance.html) do not need to be translated as they are generated from the markdown (e.g. performance.md). We used to store these generated chapter HTML files in git, but no longer do so probably can remove the statement related to that as probably more confusing than useful. Then again if you run the site locally (see instructions in That make sense, or have a just confused you more than helped? 😀 |
alright, nah that helped thanks |
@noah-vdv thanks for your help translating this content! I see the base templates have been checked off. Have those translations been submitted yet? |
No problem. |
Feel free to open a draft PR for now and I can give feedback. To @rviscomi ’s point we normally put your name beside something you’re working on (so others don’t work on it too) but only tick it off after PR is accepted to show its “done”. I’ve updated the first comment to that now. |
BTW since you've done the base templates we're ready to send this language live so (at the risk of making this PR even bigger!) can you add Dutch to |
Should I translate content such as First Input Delay or keep it as is? |
I would say not as it's a technical term. Not quite code, but close enough. Maybe add the Dutch translation after first time it's used. |
What has changed in the 2020 base.html file for it to be translated? |
Oh. Looks like you already got the foreword. Most languages didn't. Will remove that one! Did you see there were some changes to Markup chapter? |
Alright, yeah I'll get to those before I do the seo chapter |
I was going through the 2020 seo chapter and realized there's still 3 |
And in some other chapters as well so I'll just do those later |
Good spot. I've reviewed them and happy to just remove them. I count 4 though not three (though one is not marked as a TODO but a Note):
Seems pretty obvious to me so don't think it needs further comment. Maybe it was added since that comment was added.
Yeah would have been nice to have some interpretation rather than just the stats, but not only chapter to do this, so let's leave for now and remove the TODO.
Rick edited this and I trust his understanding of Lighthouse so to me this is just a comment for Authors during review so TODO can be removed.
Same as above so TODO can be removed. Would you mind removing them from English version too as part of this PR?
I'll try to review those similarly and submit a PR for them. I see Compression, JavaScript, Privacy (currently under re-review anyway), Resource-Hints (this TODO can be removed), Security (not edited yet anyway), and SEO (discussed above). Hold off translating them for now but SEO and Resource Hints can be done. |
Just a heads up: the 2020 ecommerce chapter has |
Yeah we never got a bio from @jrharalson - Jason if you see this and wanna provide one then please do. It appears at the bottom of the chapter. Agree on the featured stat correction. |
Should Caching entity stay as is or be translated? As well as anywhere else in the chapter
|
I would translate it. It's not a technical term as such. Same for Eviction and Revalidation further down that list. On the other hand, Time to Live (TTL) is a well-known technical term so I wouldn't translate that, |
Also, I noticed Expiries instead of Expires , that's a typo right?
|
Yup! Good spot. If you could fix as part of your translation pull request that would be much appreciated! |
Wow only 3 chapters to go! Thank you @noah-vdv for your amazing effort!! |
Hey @noah-vdv any chance we could persuade you back to finish off the final to chapters for 2020? Once we have those we can publish the ebook in Dutch! And we’ll even print a copy as a small token of our appreciation you for your efforts! |
Hey, wow time has flown! Didn't realise how long ago I had last worked on this. Anyways, yeah of course! However, I don't have as much spare time as before but I'll try my best to get it done, hopefully, by November.
Awesome!! Looking forward to finishing it off! 👍 |
We added a small note to our Accessibility Statement about colour contrast issues: almanac.httparchive.org/src/templates/nl/accessibility_statement.html Lines 69 to 71 in 14f8512
Would be great if someone could translate this (@noah-vdv ?). Very small and easy! |
"In sommige hoofdstukken nemen we ook andere inhoud op de site op, die niet door onszelf is gemaakt, waaronder YouTube-video's, pdf-links of links naar andere artikelen, die niet voldoen aan de strikte criteria die vereist zijn voor WCAG 2.1 level AAA. Zie onderstaande opmerking over externe inhoud."
Also, i hate to disappoint, but this is taking more time as I need to spend more time on my study than expected. I, unfortunately can't give you an eta yet. |
No probs. Thanks for that translation. |
Doh! Looks like I gave you the wrong bit of text to translate above :-( That was the next paragraph that was already translated. This was the paragraph I actually wanted translated:
|
We erkennen dat sommige keuzes voor kleuren in onze visualisaties niet voldoen aan de kleurcontrastvereisten van de WCAG. We doen een bewuste inspanning om de meer contrasterende kleuren en opschriften te gebruiken om de impact hiervan te verminderen. We hopen dat de gedetailleerde beschrijvingen alsook toegang tot de onderliggende gegevens zelf kunnen helpen met dit probleem. We streven ernaar de toegankelijkheid van de kleurschema's in onze visualisaties de komende jaren te verbeteren. |
Bedankt @VictorLeP ! Zeer gewaardeerd. |
Will also take a stab at translating this year's Privacy chapter (since @noah-vdv is busy). |
These are the core templates - without which we cannot release any translated chapters. They are in the language specific templates directory:
2022
2021
2020
2019
These are the chapters to be translated, in rough order of popularity. They exist in the content directory:
2022
2021
2020
2019
Additionally the following pages need translated too in the language specific templates directory:
There is no need to translate the chapters HTML pages as they are generated off the markdown combined with the above templates.
Please include "Makes progress on #1750" in all pull requests so a link is created from the PR to this issue.
Common notes for writing consistency are here: https://github.com/HTTPArchive/almanac.httparchive.org/wiki/Translators'-Guide. Feel free to edit that and/or add Dutch-specific extras by editing this comment.
Dutch specific extra advice:
The text was updated successfully, but these errors were encountered: