Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed collection info dropdown order #708

Conversation

Pratz2005
Copy link
Contributor

Improved collection info dropdown to be sorted by type and then alphabetically

Before:
image

After:
image

@Pratz2005
Copy link
Contributor Author

Fixes Issue #567

@EdwardMoyse
Copy link
Collaborator

Ah, this breaks the CI:

FAIL  src/tests/loaders/phoenix-loader.test.ts (74.257 s)
    PhoenixLoader
      ✓ should create an instance (9 ms)
      ✕ should not get the list of collections and collection with the given collection name from the event data (3 ms)
      ✓ should get the list of event names from the event data (3 ms)
      ✕ should get list of collections in the event data (4 ms)
      ✓ should get the collection with the given collection name from the event data (2 ms)
      ✓ get metadata associated to any event (2 ms)
      ✓ should get the object containing labels of events (3 ms)
      ✓ should get function to add options to scale event object type by given factor (1 ms)
      ✓ should add label of event object to the labels object (4 ms)
  
    ● PhoenixLoader › should not get the list of collections and collection with the given collection name from the event data
  
      expect(received).toBeInstanceOf(expected)
  
      Expected constructor: Array
      Received constructor: Object

@Pratz2005
Copy link
Contributor Author

Ah, ill try and solve the issue making sure it doesn't

@Pratz2005 Pratz2005 closed this Dec 19, 2024
@Pratz2005 Pratz2005 deleted the fixes#567/Pratz-fixed-ordering-collectionsinfo-dropdown branch December 19, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants