Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate opening ATLAS AOD files directly via jsroot #44

Open
EdwardMoyse opened this issue Jan 22, 2020 · 2 comments · May be fixed by #710
Open

Investigate opening ATLAS AOD files directly via jsroot #44

EdwardMoyse opened this issue Jan 22, 2020 · 2 comments · May be fixed by #710
Labels
enhancement New feature or request

Comments

@EdwardMoyse
Copy link
Collaborator

No description provided.

@EdwardMoyse EdwardMoyse added the enhancement New feature or request label Jan 22, 2020
@9inpachi
Copy link
Collaborator

@EdwardMoyse I didn't see this while working with JSROOT.

Can you share any example files? I will see what kind of data they have.
And also share the goals you have in mind for this. Thanks. ^_^

@EdwardMoyse
Copy link
Collaborator Author

@9inpachi reported that jsroot can't open ATLAS AOD files because of the compression used. :-/

AritraDey-Dev added a commit to AritraDey-Dev/phoenix that referenced this issue Jan 6, 2025
@AritraDey-Dev
fix: Fix handling of ATLAS AOD files with specific compression method
42f33a6 
Fixes HSF#44

Update `JSRootEventLoader` to handle unsupported compression method for ATLAS AOD files.

* Add import for the compression library in `packages/phoenix-event-display/src/loaders/jsroot-event-loader.ts`.
* Modify `getEventData` method to handle unsupported compression errors.
* Add `handleUnsupportedCompression` method to decompress data and read objects from the file.
* Add tests in `packages/phoenix-event-display/src/tests/loaders/jsroot-event-loader.test.ts` to verify handling of ATLAS AOD files with the new compression method.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/HSF/phoenix/issues/44?shareId=XXXX-XXXX-XXXX-XXXX).
@AritraDey-Dev AritraDey-Dev linked a pull request Jan 6, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Fix handling of ATLAS AOD files with specific compression method AritraDey-Dev/phoenix
2 participants
@EdwardMoyse @9inpachi