Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hsa_code/code_recursive_kernel_function test case broken #6

Open
pjaaskel opened this issue Nov 14, 2016 · 1 comment
Open

hsa_code/code_recursive_kernel_function test case broken #6

pjaaskel opened this issue Nov 14, 2016 · 1 comment

Comments

@pjaaskel
Copy link

The recursion result is never saved, thus this test cannot pass.

This fixes it:

--- a/src/kernels/recursive_func.hsail
+++ b/src/kernels/recursive_func.hsail
@@ -65,6 +65,7 @@ prog function &recur_add_fn(arg_u32 %out)(arg_u32 %in0, arg_u32 %in1) {
         st_arg_u32 $s0, [%arg0];
         st_arg_u32 $s1, [%arg1];
         call &recur_add_fn (%outarg)(%arg0,%arg1);
+        ld_arg_align(4)_u32 $s0, [%outarg];
     } // store the value of s0 to out, then return

 @return:
@tomiaijo
Copy link
Collaborator

Pull request #9 resolves the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants