Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A possibility to make bins with weighted averages added. #146

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

szymonharabasz
Copy link

This allows to make entires of the type: { value: 1.5, low: 1.0, high:2.0 }.
Such a feature is necessary to submit data from figures like Fig. 6 in:
https://doi.org/10.1103/PhysRevC.80.044905

This allows to make entires of the type: { value: 1.5, low: 1.0, high:2.0 }.
Such a feature is necessary to submit data from figures like Fig. 6 in:
https://doi.org/10.1103/PhysRevC.80.044905
@clelange
Copy link
Collaborator

clelange commented Oct 1, 2020

Hi @szymonharabasz - thanks a lot for this contribution! There's something with the tests, they all fail, but it doesn't seem to have anything to do with the code you added. I'll try to have a look at this next week.

Independently, do you think you could write some tests so that we can be sure this feature won't break in the future? Let me know if you need any help with that.

@AndreasAlbert
Copy link
Collaborator

Hi, indeed the linuxpy3 jobs fail mysteriously, but the linuxpy2 and macos jobs fail due to real pylint complaints:

Using config file /home/runner/work/hepdata_lib/hepdata_lib/pylintrc
************* Module hepdata_lib.__init__
C: 56, 0: Line too long (114/100) (line-too-long)
C: 94, 0: Line too long (110/100) (line-too-long)
C:189, 0: Wrong continued indentation (add 2 spaces).
                                                          self.digits)
                                                          ^ | (bad-continuation)

-----------------------------------
Your code has been rated at 9.97/10

@szymonharabasz these are prettey straightforward white space / line length isues. If you could fix these, we might get a clearer picture of what other tests are failing and why.

@szymonharabasz
Copy link
Author

szymonharabasz commented Oct 5, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants