Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup.py missing dependencies #15

Open
lukasheinrich opened this issue Sep 17, 2015 · 2 comments
Open

setup.py missing dependencies #15

lukasheinrich opened this issue Sep 17, 2015 · 2 comments

Comments

@lukasheinrich
Copy link

so I ran a freh install in a virtualenv and it seems like setup.py is missing some deps.

I needed to pip install

  • funcsigs
  • functools32
  • yoda

should I just add those as hard dependencies (maybe yoda should not be an explicit dependency, but then the hepdata-converter should not crash if there is an ImportError)

@michal-szostak
Copy link
Contributor

The system is 32bits? That would explain the problem (all testing / development infrastructure is 64bit).

The second point is actually quite reasonable, maybe we should rewrite the code, so if imports in parsers / writers fail, they just won't be available, instead of causing application crash. Any thoughts on this @eamonnmag @lukasheinrich ?

EDIT: Oh, and by the way yoda is listed as a dependency, but the only way to install it is a source compilation.

@eamonnmag
Copy link
Contributor

Or via brew for Mac. I'm updating the installation instructions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants