Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VOL should not assume all filters are optional upon re-opening dataset #90

Open
mattjala opened this issue Oct 16, 2023 · 0 comments
Open
Assignees
Labels
bug Something isn't working

Comments

@mattjala
Copy link
Collaborator

The library's filter pipeline has an optional/mandatory flag associated with each filter. Optional filters should be skipped if they fail for whatever reason, while a failure with a mandatory filter should cause the operation to fail. Wrappers that set particular filters (e.g. H5Pset_deflate, H5Pset_szip) always mark them as optional. Setting the filters using H5Pset_filter lets the user decide the optional/mandatory flag for each filter.

At the moment, the REST VOL uses wrapper functions to construct filter pipelines on re-opened datasets, setting their required parameter to "optional" in all cases. This is likely the source of this issue.

It would be possible for the REST VOL to work around this by replacing calls to wrappers with use of H5Pset_filter that preserve the required flag, but this would involve duplicating setup work done by each of those wrapper functions.

@mattjala mattjala added the bug Something isn't working label Oct 16, 2023
@mattjala mattjala self-assigned this Oct 16, 2023
@mattjala mattjala changed the title Assumes all filters are optional upon re-opening dataset VOL should not assume all filters are optional upon re-opening dataset Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant