Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove H5pubconf.h from the public API #5115

Open
derobins opened this issue Nov 14, 2024 · 0 comments
Open

Remove H5pubconf.h from the public API #5115

derobins opened this issue Nov 14, 2024 · 0 comments
Assignees
@derobins
Labels
Component - Build CMake, Autotools Component - C Library Core C library issues (usually in the src directory) Priority - 3. Low 🔽 Code cleanup, small feature change requests, etc. Type - Deprecation / Removal We strive for backward-compatibility, so it's worth noting this separately
Milestone
2.0.0

Comments

@derobins
Copy link
Member

H5pubconf.h is generated by configure and the conventional wisdom is that it should not be deployed, even with name-mangling (we prefix all symbols with H5_).

When the Autotools go away, H5pubconf.h will be replaced with a private configure file and an H5features.h file, which will include things users need to know about like if parallel HDF5 was enabled. This new header file will be included in hdf5.h (H5pubconf.h was included in H5public.h).

Ideally, users will be unaware of this change.
@derobins derobins added Component - Build CMake, Autotools Component - C Library Core C library issues (usually in the src directory) Priority - 3. Low 🔽 Code cleanup, small feature change requests, etc. Type - Deprecation / Removal We strive for backward-compatibility, so it's worth noting this separately labels Nov 14, 2024
@derobins derobins added this to the 2.0.0 milestone Nov 14, 2024
@derobins derobins self-assigned this Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@derobins derobins

Labels
Component - Build CMake, Autotools Component - C Library Core C library issues (usually in the src directory) Priority - 3. Low 🔽 Code cleanup, small feature change requests, etc. Type - Deprecation / Removal We strive for backward-compatibility, so it's worth noting this separately
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
1 participant
@derobins