Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

using elasticsearch-dsl 6.1, TypeError in DEMIndex.save #9

Closed
codekiln opened this issue Aug 3, 2018 · 0 comments
Closed

using elasticsearch-dsl 6.1, TypeError in DEMIndex.save #9

codekiln opened this issue Aug 3, 2018 · 0 comments
Assignees
@codekiln
Labels
bug Something isn't working

Comments

@codekiln
Copy link
Contributor

codekiln commented Aug 3, 2018 •
edited
Loading

In elasticsearch-dsl==6.1, ESIndex.save() does not take a parameter using like it does when elasticsearch-dsl==6.2. While full support for 6.2 will be implemented in #3, a few parameters have been added to support 6.2, and this is one place where backwards-compatible support is needed.
@codekiln codekiln self-assigned this Aug 3, 2018
codekiln added a commit that referenced this issue Aug 3, 2018
@codekiln
#9 type error DEMIndex save
db93980
codekiln added a commit that referenced this issue Aug 3, 2018
@codekiln
add test to ensure that multiple versions of DEM work with DEMIndex.save
4b30859 
#9 type error DEMIndex save
@codekiln codekiln added the bug Something isn't working label Aug 3, 2018
codekiln added a commit that referenced this issue Aug 3, 2018
@codekiln
bump version to 0.6.1 and update changelog
603e7a4 
#9 type error DEMIndex save
@codekiln codekiln mentioned this issue Aug 3, 2018
Merged
codekiln added a commit that referenced this issue Aug 3, 2018
@codekiln
Merge pull request #10 from HBS-HBX/#9_type_error_DEMIndex_save
2e26553 
closes #9 type error DEMIndex save
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codekiln codekiln

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@codekiln