Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

316 make the encryption optional #329

Merged
merged 6 commits into from
Oct 28, 2024
Merged

316 make the encryption optional #329

merged 6 commits into from
Oct 28, 2024

Conversation

SRichner
Copy link
Collaborator

@casaout looking at this now, the emphasis on (...single) *file was created* (based...) seems a bit weird. What do you think?

image

@SRichner SRichner requested a review from casaout October 21, 2024 17:04
@SRichner SRichner self-assigned this Oct 21, 2024
@SRichner SRichner linked an issue Oct 21, 2024 that may be closed by this pull request
Make the Encryption optional #316
Open
@casaout
Copy link
Member

casaout commented Oct 21, 2024

@casaout looking at this now, the emphasis on (...single) *file was created* (based...) seems a bit weird. What do you think?

image

I agree - should we call it an export file was created or a data-file (related to how we refer to it elsewhere)?

casaout
casaout reviewed Oct 21, 2024
View reviewed changes
src/electron/src/views/DataExportView.vue Outdated
@@ -219,8 +220,9 @@ function revealItemInFolder(event: Event) {
<p>
Please click "Next" once you are ready to
<b class="dark:text-white">first review, and later share your data</b>. The export
that will be created with your permission in the next step will be encrypted and
password-protected.
that will be created with your permission in the next step will be
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how will this read if dataExportEncrypted==false?

Isn't it:

The export that will be created with your permission in the next step will be.

Should we hide the entire sentence?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, updated so it hides the complete sentence

@SRichner
Copy link
Collaborator Author

@casaout looking at this now, the emphasis on (...single) *file was created* (based...) seems a bit weird. What do you think?
image

I agree - should we call it an export file was created or a data-file (related to how we refer to it elsewhere)?

How about Your data was exported and we created a file based on your preferences on the previous page. To share this file with the researchers, please take the following steps:?

@SRichner SRichner merged commit 428bb44 into dev Oct 28, 2024
@SRichner SRichner deleted the 316-make-the-encryption-optional branch October 28, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@casaout casaout casaout approved these changes

Assignees

@SRichner SRichner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make the Encryption optional
2 participants
@SRichner @casaout