Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bahro Cave: Only Garrison's Pole Fully Animates #246

Open
patmauro opened this issue Nov 1, 2023 · 6 comments
Open

Bahro Cave: Only Garrison's Pole Fully Animates #246

patmauro opened this issue Nov 1, 2023 · 6 comments

Comments

@patmauro
Copy link
Contributor

patmauro commented Nov 1, 2023

Noticed this (unrelated!) issue while verifying #244:

(Since this may be misleading - the title is referring to how much of the physical pole animates, not whether the animation completes.)

3/4 of the poles in Bahro Cave only feature the snow animation in the center of the pole, but not the "cap" (or bottom). However, Garrison's pole also features animation in the cap:
image

At first, it seems like the Garrison pole is the one that is incorrect, but when we compare to the poles in Relto, the entire pole always animates.
image

First, need to determine: Which was the intended design? If "whole pole" is the correct design, then the other 3 poles in Bahro Cave need to be fixed. However, if "center only" is the correct design, then the Garrison pole needs to be fixed in Bahro Cave, and then all four poles need to also be corrected in Relto.

See if there are any clues in texture, code, etc that might give a better clue as to which the "correct" design is. There may be hints in the texture files.

@dpogue
Copy link
Member

dpogue commented Nov 1, 2023

Is it consistent between the blue and orange Bahro caves (i.e., when you initially collect the poles vs when you return them)?

@patmauro
Copy link
Contributor Author

patmauro commented Nov 1, 2023

Is it consistent between the blue and orange Bahro caves (i.e., when you initially collect the poles vs when you return them)?

Yup:
bahrocave

My hunch so far is that it's supposed to be only the middle bit on those poles that animates, and this is a case of a good old fashioned art mismatch between ages. I'll dig through textures & other art sources to try to confirm this theory.

@EhrenCG
Copy link
Contributor

EhrenCG commented Nov 1, 2023

I feel pretty confident saying the entire poles are supposed to be lit up. It's what the history suggests.
BahroPoleTops

@patmauro
Copy link
Contributor Author

patmauro commented Nov 1, 2023

I feel pretty confident saying the entire poles are supposed to be lit up. It's what the history suggests. BahroPoleTops

Confirmed - It definitely seems like all four are supposed to be lit up. That settles that I think!

This is actually pretty good news: (a) this limits the scope of this issue to just the bahro cave, which is nice, and (b) the solution we're looking for probably lies in CC.

@Hazado
Copy link
Contributor

Hazado commented Nov 2, 2023

The mesh itself has had the snow texture removed from the top part of the poles in the moula bahro caves.
Screenshots from blender imports

The snow mesh applied to the URU CC bahro cave
image

The snow mesh applied to the Moula bahro Cave
image

@Hazado
Copy link
Contributor

Hazado commented Nov 2, 2023

So I fixed this in a local test by importing the drawable span from uru CC and nulling the materials we dont need.
Move where the draw interface is pointing and bam fixed mesh. Increases the size of the file a little but yes the Uru CC mesh will fix the issue here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants