diff --git a/guake/prefs.py b/guake/prefs.py index 1ecc3a56e..26869ff1e 100644 --- a/guake/prefs.py +++ b/guake/prefs.py @@ -536,8 +536,14 @@ def on_font_style_font_set(self, fbtn): self.settings.styleFont.set_string("style", fbtn.get_font_name()) def on_background_image_file_chooser_file_changed(self, fc): + # only allow files with these extensions + allowed_extensions = (".jpg", ".jpeg", ".png", ".gif") + filename = "" + if fc.get_filename() and fc.get_filename().endswith(allowed_extensions): + filename = fc.get_filename() + self.settings.general.set_string( - "background-image-file", fc.get_filename() if fc.get_filename() else "" + "background-image-file", filename ) def on_background_image_file_remove_clicked(self, btn): diff --git a/releasenotes/notes/prevent_nonimage_file_as_background-9f2d4e6b8c7a0a5e.yaml b/releasenotes/notes/prevent_nonimage_file_as_background-9f2d4e6b8c7a0a5e.yaml new file mode 100644 index 000000000..2416fcd15 --- /dev/null +++ b/releasenotes/notes/prevent_nonimage_file_as_background-9f2d4e6b8c7a0a5e.yaml @@ -0,0 +1,8 @@ +release_summary: > + Prevent the use of non-image files as the background image. The following file extensions are allowed: .jpg, .jpeg, .png, .gif + + +fixes: + - | + + - Prevent users from setting non-image files as a background image, closes #2205