-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand Observation + Action to check for game-ending topology changes #597
Comments
Hello, Sorry for the late reply. This sounds like a super interesting idea. I am not sure the current implementation you propose is correct though. To check this we need to run an algorithm to check if the graph is connected or not. For example you could have one part of the graph with substation 0, 1 and 4 and all the substations connected together (for example by disconnecting lines 4->5, 4->3, 1->3 and 1-> 2). And if my understanding of your algorithm is correct, this would be ok (but maybe I read it too fast, sorry if I'm wrong here) One solution would be to convert the action to a networkx graph and then run a I'll try to work on it ASAP but it will probably not be in grid2op 1.10.2 release unfortunately |
Wahou, awesome work thank you :-) Let me know if something can be done on my end. Best Benjamin |
Not sure, we are currently using it to check whether a maintenance action is safe. Since it only works for power line status changes (won't generalize to substation topology changes) its utility is somewhat limited. Can make a pull request but not sure where it would belong? |
Expand Observation + Action to check for game-ending topology changes
I am playing around with the various options to simulate the environment. In the latest version there appear to be 4 ways:
I wanted to do a quick topology check to see that my agent does not isolate any substations For this I wanted to use Observati
Ex. This is what i do:
However, the Observation + Action method does not return a sensible bus_connectivity_matrix() nor get_energy_graph():
Since there are no power flows, the energy graph is naturally empty. The bus connectivity graph is also empty, however, which I would not expect. This appears to be because "(obs + action)._done" is always True.
While the comments on add_act() method state that this functionality is not intended to check for game over conditions, it does seem to me like it would be perfect for checking if a substation (and hence any connected elements) becomes disconnected.
An equality check between the elements matrix before and after the action can see if anything has been disconnected, but this will also return False for legal bus changes (such as the
change from bus 1 to 2 on Substation 12 below):
Describe alternatives you've considered
Interestingly if I set "_done = False" on the sim_obs I can get access the bus_connectivity matrix. Not sure if this is intended behaviour, but seems to me it would be nicer to be able to access it since it is not actually a game over.
Additional context
Working on extending this into a topology-check PR.
The text was updated successfully, but these errors were encountered: