Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compress with file selector should host form in unprotected caller workbook, in case addin book is protected #1

Open
Greedquest opened this issue Jul 26, 2018 · 2 comments
Labels
enhancement New feature or request

Comments

@Greedquest
Copy link
Owner

When running from a protected addin, a new userform cannot be added to the protected project - causing CompressProjectFileSelector to fail.

A fix would be to generate any forms in the caller workbook as this is necessarily unprotected, or to flag earlier

@Greedquest
Copy link
Owner Author

Greedquest commented Jul 29, 2018

Should be fixed by f10560e

@Greedquest
Copy link
Owner Author

Now fixed; private projects must contain template form with cmd_1,lst_1 and code to hide the form on cmd_1_clicked. Un-protected projects make their own form as before.

Better would be if the unprotected caller workbook always hosted the userform; a code module would need to be added to it by the addin workbook. That module would contain a function to create the form, read the results and remove the form, then return the results. Tricky but not impossible

@Greedquest Greedquest changed the title Compress with file selector won't work if project is protected Compress with file selector should host form in unprotected caller workbook, in case addin book is protected Aug 3, 2018
@Greedquest Greedquest added the enhancement New feature or request label Aug 3, 2018
@Greedquest Greedquest reopened this Sep 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant