Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy template support #2087

Open
9 tasks
zackkatz opened this issue Jul 25, 2024 · 0 comments · May be fixed by #2088
Open
9 tasks

Remove legacy template support #2087

zackkatz opened this issue Jul 25, 2024 · 0 comments · May be fixed by #2088

Comments

@zackkatz
Copy link
Member

zackkatz commented Jul 25, 2024

In Version 2.0, we did our best to not break backward-compatibility with any templates that had been customized in version 1.x. This was a major lift and, in retrospect, a mistake.

Not many users had overridden the template files, but to accomodate them, we added a lot of code that continues to this day.

We need to remove that code now in order to simplify the codebase while also making transitioning to the next API less painful.

Todo

  • Migrate Edit Entry template files to use Template 2.0
  • Migrate the Search Bar template files to use Template 2.0
  • Remove all \GV\Mocks\Legacy_Context::push() and \GV\Mocks\Legacy_Context::pop() state managers
  • Remove all deprecated fields
    • Ensure that deprecated fields, when not found, fail gracefully
  • Remove Legacy_Override_Template()
  • Add a stub for all removed classes so that fatal errors are avoided
    • Legacy_Override_Template
    • \GV\Mocks\Legacy_Context

Considerations

  • What legacy classes should we keep, such as View_Legacy_Template?
  • What about legacy search CSS (templates/deprecated/css/gv-legacy-search.css)?

This issue is a beginning of a bigger project, but should get the ball rolling.

@zackkatz zackkatz linked a pull request Jul 25, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant