Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

click twice is needed to Join a project in Join button for unregistered users. #372

Open
atfornes opened this issue May 9, 2017 · 10 comments

Comments

@atfornes
Copy link
Contributor

atfornes commented May 9, 2017

No description provided.

@atfornes
Copy link
Contributor Author

SessionSvc.loginRequired should be used propertly to solve this issue.

@krshubham
Copy link
Contributor

join.js:40
What is joinModel?
Should it be joinModal?

@atfornes
Copy link
Contributor Author

@krshubham, that is right, well seen!

@atd
Copy link
Member

atd commented May 29, 2017

@atfornes
Copy link
Contributor Author

Thanks @atd

I did a quick search for joinModel and only saw that one, I forgot about the difference in capitalization used in the templates join-model vs joinModel. It is great you detect it!

@atd
Copy link
Member

atd commented May 29, 2017

😉 👍

@krshubham
Copy link
Contributor

Yes it should be joinModel only. I was also wondering because it just stopped working! I should've have done that search before asking! 👍

@krshubham
Copy link
Contributor

krshubham commented May 29, 2017

@atfornes
can we please have some steps to reproduce the issue, I tried this 2-3 times and I was not able to reproduce the issue. Thanks!

@atfornes
Copy link
Contributor Author

@krshubham, the steps are as follows, if you cannot reproduce, we can close the issue.

  1. as not logged in user click in a join button of a project
  2. fill the form with your email and join text and click join
  3. click start participating
  4. register as new user
  5. after registering, the user should be logged in and added to the project.

@krshubham
Copy link
Contributor

krshubham commented May 29, 2017

@atfornes
The modal disappears after I register.
It does not happen in my dev setup, however I can see it happen on the currently deployed app! This should not happen 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants