Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pb on the graphs of the first page #154

Open
jdigne opened this issue Jul 22, 2020 · 3 comments · Fixed by #155
Open

pb on the graphs of the first page #154

jdigne opened this issue Jul 22, 2020 · 3 comments · Fixed by #155
Assignees
@nmellado
Labels
website-bug Something isn't working on the website

Comments

@jdigne
Copy link
Contributor

jdigne commented Jul 22, 2020

https://replicability.graphics/index.html#project
The graph value for "hard to reproduce using pseudo-code" counts more papers than there are "Total(only pseudo-code)".
On the data page the graphs seem to be correct.
@jdigne jdigne added the website-bug Something isn't working on the website label Jul 22, 2020
nmellado added a commit that referenced this issue Jul 23, 2020
@nmellado
Fixes #154
d34b876 
Fix issue #154 

The error is caused by a change of logic in the json files: this script expects an empty field for `pseudocode score` when there is no pseudocode.
See warnings in error log: https://github.com/GraphicsReplicability/replicability.graphics/runs/898876115?check_suite_focus=true#step:3:761

Fix: Check only the pseudocode state when pseudocode is available.
@nmellado nmellado mentioned this issue Jul 23, 2020
Merged
@dcoeurjo dcoeurjo linked a pull request Jul 23, 2020 that will close this issue
Fixes #154 #155
Merged
dcoeurjo added a commit that referenced this issue Jul 23, 2020
@nmellado @dcoeurjo
Fixes #154 (#155)
85af01f 
* Fixes #154

Fix issue #154 

The error is caused by a change of logic in the json files: this script expects an empty field for `pseudocode score` when there is no pseudocode.
See warnings in error log: https://github.com/GraphicsReplicability/replicability.graphics/runs/898876115?check_suite_focus=true#step:3:761

Fix: Check only the pseudocode state when pseudocode is available.

* Remove tabulations introuced by github editor

* Update scripts/generatePagesFromConsolidatedJSON.py

Co-authored-by: David Coeurjolly <[email protected]>
@nmellado
Copy link
Contributor

Now the graphs are emtpy. Re-openning.

@nmellado nmellado reopened this Jul 23, 2020
@dcoeurjo
Copy link
Contributor

dcoeurjo commented Sep 8, 2020

Is this issue still active ?

@nmellado
Copy link
Contributor

nmellado commented Sep 8, 2020

Yes, graphs entries are always Equals to 0 for pseudo code (my fix was apparently wrong..)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nmellado nmellado

Labels
website-bug Something isn't working on the website
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #154 GraphicsReplicability/replicability.graphics
3 participants
@dcoeurjo @nmellado @jdigne