Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHANGE_LOG missing: BE_ListFilesInFolder is not in version 4.2.0, was it renamed to BE_FileListFolder ? #202

Open
wujoho opened this issue Sep 2, 2021 · 4 comments

Comments

@wujoho
Copy link

wujoho commented Sep 2, 2021

If BE_ListFilesInFolder was renamed to BE_FileListFolder, the new function is not compatible with BE_ListFilesInFolder's parameters?

@nickorr
Copy link
Member

nickorr commented Sep 3, 2021

A rename doesn't affect the parameters. Not sure what you're referring to here...

Also if you need plugin support please use : https://docs.baseelementsplugin.com There's a contact link on that page.

We try to keep GitHub issues to things related to the c++ code, or compiling etc.

Cheers,
Nick

@wujoho
Copy link
Author

wujoho commented Sep 3, 2021

sorry for the confusion, hope the below makes it a bit clearer here.

BE_ListFilesInFolder was in old version like 3.1 but not in latest version, and I couldn't find its changing history like when removed or rename in the CHANGE_LOG page

Also if BE_ListFilesInFolder was renamed to BE_FileListFolder, then they take different parameters, it was valid to use BE_ListFilesInFolder ( folderPath ; "*.txt" ) in old version, but in new version BE_FileListFolder doesn't take "*.txt" for the second parameter.

@nickorr
Copy link
Member

nickorr commented Sep 6, 2021

I don't believe that it ever had an option for limiting the file names returned. We've had options to do that generally via regex, but never in this function, that I'm aware of.

@wujoho
Copy link
Author

wujoho commented Sep 6, 2021

yes, you are correct, i double checked this function in version 3.1.0, it doesn't support filtering by file type like the above, it was a misuse in our code, sorry for the confusion.

So it's just the below part:
BE_ListFilesInFolder was found in old version like 3.1, but couldn't find it in the latest version, also couldn't find its changing history like when it was removed or was rename in the CHANGE_LOG

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants