Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide consistent story on dependencies #5

Open
woodt opened this issue Feb 16, 2021 · 0 comments
Open

Provide consistent story on dependencies #5

woodt opened this issue Feb 16, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@woodt
Copy link
Contributor

woodt commented Feb 16, 2021

Currently there are two unrelated sets of dependency information in the repo:

  • pyproject.toml
  • requirements.*

Main issue is they are not in sync; secondary issue is that the custom scripts used to maintain the requirements.txt file are not a well-known pattern, and probably deserve a mention in the README.

Ideally, there would be one source of truth. Recent versions of pip seem to deal with installing dependencies successfully from the pyproject.toml file, so in theory we don't need the requirements files at all.

Work on this issue should clean up the requirements story so that:

(1) there is one source of truth
(2) if we need alternate representations of the dependencies (e.g., a requirements.txt file) they should be generated from the source of truth.

@woodt woodt added the bug Something isn't working label Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant