Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/NPC-walking-fixes #364

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feature/NPC-walking-fixes #364

wants to merge 3 commits into from

Conversation

JaXt0r
Copy link
Contributor

@JaXt0r JaXt0r commented May 24, 2024 •
edited
Loading

What's done:

  • I changed lookup of end locations from Sphere Colliders of Waypoints/Freepoints to a Vector.Distance() lookup. Due to the fact, that some NPCs spawn directly next or inside a collider, which causes frictions. The new lookup is better aligned with original Gothic logic.

To test

  1. Spawn Grim (580) a few times and look if he walks into the music stage - if he just stands around the fire, we're fine. (Lowered search distance for a place to pee. Before the fix, he walked into the inner circle's walls to pee)
  2. Guard (214) should stay in front of door (Before the fix, he walked through walls)

@JaXt0r JaXt0r changed the title fix(NpcHelper): Lowered lookup distance. (Otherwise PEE fps will be s… feature/NPC-walking-fixes May 24, 2024
@JaXt0r
fix(DestinationReached): Whenever NPCs walk to an FP or WP, they will…
b125de6 
… now hit it as we leverage Vector3.Distance() (which is better, as some NPCs spawn next/in colliders already).
@JaXt0r JaXt0r marked this pull request as ready for review May 31, 2024 03:00
@JaXt0r JaXt0r linked an issue May 31, 2024 that may be closed by this pull request
Change NPC FP/WP/ZS_* collision behaviour from Colliders to Vector3.Distance checks #350
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Redreaper666 Redreaper666 Awaiting requested review from Redreaper666

@JucanAndreiDaniel JucanAndreiDaniel Awaiting requested review from JucanAndreiDaniel

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change NPC FP/WP/ZS_* collision behaviour from Colliders to Vector3.Distance checks
1 participant
@JaXt0r