New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Look into potential performance enhancement regarding vocabulary generation #2

Open

itsmontoya opened this issue Jul 11, 2024 · 0 comments

Assignees

Collaborator

itsmontoya commented Jul 11, 2024

I received some review notes from @chewxy

the algorithm looks correct
I think there may be plenty of efficiency to be gained by hoising Vocabulary out of the loop process
basically, have one pass to make Vacabulary first
but what you have here? absolutely should work

itsmontoya self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment