-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade buildpacks (and transitive dependencies) #9572
Open
plumpy
wants to merge
8
commits into
GoogleContainerTools:main
Choose a base branch
from
plumpy:upgrade_buildpacks_2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+179,178
−89,826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plumpy
force-pushed
the
upgrade_buildpacks_2
branch
from
November 15, 2024 21:32
7323b79
to
11dfbc8
Compare
plumpy
force-pushed
the
upgrade_buildpacks_2
branch
from
November 15, 2024 22:32
11dfbc8
to
069ad08
Compare
plumpy
changed the title
chore: upgrade buildpacks
chore: upgrade buildpacks (and transitive dependencies)
Nov 15, 2024
One notable weird-looking one: the ENV parser now returns an extra node that we don't care about, but need to skip over (hence the extra .Next): moby/buildkit@6cfa459#diff-fd43849f96a0922a8f35c99c62006a3b0b48449edc65f60042ccc9337d1e0ca0
plumpy
force-pushed
the
upgrade_buildpacks_2
branch
from
November 16, 2024 23:00
069ad08
to
3ce5d8a
Compare
mattsanta
reviewed
Nov 18, 2024
Looks like there's also issues with the CI build. |
mattsanta
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started with just buildpacks and all of its transitive dependencies, since it seemed to be the most troublesome.
More to come in future PRs.