Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: Add a corev1.Secret support for valuesFileRefs #1207

Open
iiskandarov-clgx opened this issue May 2, 2024 · 1 comment
Open

Feature Request: Add a corev1.Secret support for valuesFileRefs #1207

iiskandarov-clgx opened this issue May 2, 2024 · 1 comment

Comments

@iiskandarov-clgx
Copy link

Would be great to use corev1.Secret as valuesFileRefs reference together or instead of corev1.ConfigMap to mount them in reposync_controller and rootsync_controller

Use case:
Interpolated sensitive values
@iiskandarov-clgx iiskandarov-clgx changed the title Feature Request: Add a Feature Request: Add a corev1.Secret support for valuesFileRefs May 2, 2024
@sdowell
Copy link
Contributor

sdowell commented Jun 28, 2024

I think this should be a feasible API change. We can add a kind field to valuesFileRefs which accepts values of ConfigMap or Secret. It would need to default to ConfigMap for backwards compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sdowell @iiskandarov-clgx