Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remaining fields to TPU VM resource #1629

Conversation

modular-magician
Copy link
Collaborator

b/292585830

This adds the remaining fields to google_tpu_v2_vm that are available from the API.

Notable exceptions (which may end up making it into this PR):

  • accelerator_config
    • This conflicts with accelerator_type, and we'll need to work around the existing default behavior

One other interesting piece is service_account.scopes. If the user specifies this field but does not include https://www.googleapis.com/auth/pubsub, it will be automatically added by the server, so I've added a diff_suppress to ignore that value.

Release Note Template for Downstream PRs (will be copied)

tpuv2: added more fields to `google_tpu_v2_vm` resource, including `network_config`, `scheduling_config`, `shielded_instance_config`, `service_account` and `data_disks`

Derived from GoogleCloudPlatform/magic-modules#9308

* Revert "Skip generated tests for google_tpu_v2_vm (#9315)"

This reverts commit 5dc9f2ea88610c0d2a2a94d04548d60e90e1cc54.

* Add remaining fields to TPU VM resource

* Change update test to use preemptible vm

* Retain disk in test so that it isn't removed prematurely

* Add networking fields

* Respond to PR comments

* More tweaks from PR comments

* Tweak test names based on feedback
[upstream:b48fc2d24968dc972360eb82c704b4eaeb8b40ba]

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician requested a review from a team as a code owner October 23, 2023 13:20
@modular-magician modular-magician requested review from roaks3 and removed request for a team October 23, 2023 13:20
@modular-magician modular-magician merged commit d7fad0e into GoogleCloudPlatform:main Oct 23, 2023
3 checks passed
@modular-magician modular-magician deleted the downstream-pr-b48fc2d24968dc972360eb82c704b4eaeb8b40ba branch November 18, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant