Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

postgresqlreceiver doesn't have all metrics #359

Open
sophieyfang opened this issue Jan 26, 2022 · 4 comments
Open

postgresqlreceiver doesn't have all metrics #359

sophieyfang opened this issue Jan 26, 2022 · 4 comments
Labels

Comments

@sophieyfang
Copy link
Contributor

sophieyfang commented Jan 26, 2022

In ops-agent github doc, it says it has 7 metrics. While in the ops-agent 2.9.0, there are only 4 that are ingested.
image

The missing metrics are:

postgresql.blocks_read
postgresql.rows
postgresql.operations

I can see those metrics names came from:
https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/v0.41.0/receiver/postgresqlreceiver/metadata.yaml
As i don't see we exclude any metrics, thus It might be upstream issue.

Also, we may want to test complete metrics name in https://github.com/GoogleCloudPlatform/ops-agent/blob/master/integration_test/third_party_apps_data/applications/postgresql/metric_name.txt @qingling128 @martijnvans

@dehaansa
Copy link
Contributor

There are two different vectors of collection in the postgresql collection. The 4 metrics you have are collected from a default client (usually against postgres database), and the other 3 metrics must be collected from a client that connects to each database individually. It would seem that your authentication method doesn't give access to the other databases present OR you have no non-template databases present on the instance other than the default.

Can you check your logs to see if there are any errors from the opentelemetry-collector component of the ops agent?

@qingling128
Copy link
Contributor

Side note: One thing we'd like to see is improved test coverage for metrics. Now that https://github.com/GoogleCloudPlatform/ops-agent/blob/master/integration_test/third_party_apps_test.go is fully open sourced, we should adjust it to verify a list of metrics for each application. @dehaansa Let's discuss in the next sync to see whether we could get this prioritized.

@rafaelwestphal
Copy link
Contributor

image
This seems to have been fixed

Copy link

This issue was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants