From c36ed4f191a3550b1e1e5761bf17bfb01f90be7d Mon Sep 17 00:00:00 2001 From: Rob Percival Date: Wed, 9 Jan 2019 15:38:38 +0000 Subject: [PATCH] Fix crash when resource has no metadata The log() call would attempt to log resource["metadata"]["name"], which would crash if the resource had no metadata. Now, it will print "None" for the name instead. --- marketplace/deployer_util/set_ownership.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/marketplace/deployer_util/set_ownership.py b/marketplace/deployer_util/set_ownership.py index 14682f40..631048ae 100755 --- a/marketplace/deployer_util/set_ownership.py +++ b/marketplace/deployer_util/set_ownership.py @@ -111,8 +111,9 @@ def dump(outfile, resources, included_kinds, app_name, app_uid, to_be_dumped = [] for resource in resources: if included_kinds is None or resource["kind"] in included_kinds: - log("Application '{:s}' owns '{:s}/{:s}'".format( - app_name, resource["kind"], resource["metadata"]["name"])) + name = resource["metadata"]["name"] if "metadata" in resource else None + log("Application '{:s}' owns '{:s}/{:s}'".format(app_name, + resource["kind"], name)) resource = copy.deepcopy(resource) set_resource_ownership( app_uid=app_uid,