Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error is thrown if test values.yaml is empty in helm based deployers #479

Open
vcanaa opened this issue Feb 7, 2020 · 2 comments
Open
Assignees

Comments

@vcanaa
Copy link
Contributor

vcanaa commented Feb 7, 2020

If test values.yaml is empty, the yaml parser returns None when the deployer tries to overlay it on top of the real values.yaml

Traceback (most recent call last):
File "/bin/overlay_test_files.py", line 45, in
overlay_yaml_file(orig, dest)
File "/bin/yaml_util.py", line 47, in overlay_yaml_file
add_or_replace(y1, y2)
File "/bin/yaml_util.py", line 30, in add_or_replace
for key in orig:
TypeError: 'NoneType' object is not iterable

@vcanaa vcanaa self-assigned this Feb 10, 2020
@devilleweppenaar
Copy link

I can confirm this is still an issue. Does anyone know of a fix or workaround?

@devilleweppenaar
Copy link

I ended up defining a value that is not used anywhere or defined in any of the subcharts:

Chart values.yaml:

placeholder: {}

Annoying but effective. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants