Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add accelerator_config to google_tpu_v2_vm #9332

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

roaks3
Copy link
Contributor

@roaks3 roaks3 commented Oct 23, 2023

b/292585830

Follow-up to #9308

This adds accelerator_config, which is a more flexible alternative to accelerator_type. Only one can be specified for creation, but both will be returned by the API.

The notable piece here is that we previously had a client-side default for accelerator_type, so adding the accelerator_config alternative without introducing a breaking change presented a challenge:

  • Since the API does not accept both fields at once, the "v2-8" default needed to be removed, so that accelerator_config could be set.
  • However, to continue supporting config without either of these fields specified the same way (default to "v2-8"), a customize diff was needed to conditionally populate the accelerator_type default.

Release Note Template for Downstream PRs (will be copied)

tpuv2: added`accelerator_config` field to `google_tpu_v2_vm` resource

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field accelerator_type default value changed from v2-8 to on google_tpu_v2_vm - reference

If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An override-breaking-change label can be added to allow merging.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 24 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 3 files changed, 146 insertions(+), 8 deletions(-))
TF Conversion: Diff ( 1 file changed, 56 insertions(+))
TF OiCS: Diff ( 1 file changed, 5 insertions(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3170
Passed tests 2848
Skipped tests: 320
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccBigQueryDataTable_bigtable|TestAccTpuV2Vm_tpuV2VmFullExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccBigQueryDataTable_bigtable[Debug log]
TestAccTpuV2Vm_tpuV2VmFullExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@roaks3 roaks3 requested review from zeleena and rileykarson October 23, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
override-breaking-change Allows a potential breaking change to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants