-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add accelerator_config to google_tpu_v2_vm #9332
Conversation
Hi there, I'm the Modular magician. I've detected the following information about your changes: Breaking Change(s) DetectedThe following breaking change(s) were detected within your pull request.
If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 1 file changed, 24 insertions(+), 2 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccBigQueryDataTable_bigtable|TestAccTpuV2Vm_tpuV2VmFullExample |
Rerun these tests in REPLAYING mode to catch issues
|
b/292585830
Follow-up to #9308
This adds
accelerator_config
, which is a more flexible alternative toaccelerator_type
. Only one can be specified for creation, but both will be returned by the API.The notable piece here is that we previously had a client-side default for
accelerator_type
, so adding theaccelerator_config
alternative without introducing a breaking change presented a challenge:accelerator_config
could be set.accelerator_type
default.Release Note Template for Downstream PRs (will be copied)