Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip generated tests for google_tpu_v2_vm #9315

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Skip generated tests for google_tpu_v2_vm #9315

merged 1 commit into from
Oct 20, 2023

Conversation

zli82016
Copy link
Member

@zli82016 zli82016 commented Oct 19, 2023

Skip generated tests for google_tpu_v2_vm, as the tpu vm node capacity is limited.

Release Note Template for Downstream PRs (will be copied)


@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 10 deletions(-))
Terraform Beta: Diff ( 2 files changed, 170 deletions(-))

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 10 deletions(-))
Terraform Beta: Diff ( 3 files changed, 39 insertions(+), 170 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3158
Passed tests 2839
Skipped tests: 317
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccBigQueryDataTable_bigtable|TestAccDataSourceGoogleServiceAccountIdToken_impersonation

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccBigQueryDataTable_bigtable[Debug log]
TestAccDataSourceGoogleServiceAccountIdToken_impersonation[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 10 deletions(-))
Terraform Beta: Diff ( 3 files changed, 44 insertions(+), 170 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3161
Passed tests 2844
Skipped tests: 317
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

@zli82016 zli82016 requested review from a team and trodge and removed request for a team October 20, 2023 16:58
@zli82016 zli82016 merged commit 5dc9f2e into main Oct 20, 2023
7 checks passed
@zli82016 zli82016 deleted the tpuv2-tests branch October 20, 2023 23:35
roaks3 added a commit that referenced this pull request Oct 21, 2023
roaks3 added a commit that referenced this pull request Oct 23, 2023
* Revert "Skip generated tests for google_tpu_v2_vm (#9315)"

This reverts commit 5dc9f2e.

* Add remaining fields to TPU VM resource

* Change update test to use preemptible vm

* Retain disk in test so that it isn't removed prematurely

* Add networking fields

* Respond to PR comments

* More tweaks from PR comments

* Tweak test names based on feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants