Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iamMember to access for BigQuery dataset #9288

Conversation

syou6162
Copy link
Contributor

@syou6162 syou6162 commented Oct 17, 2023

In google_bigquery_dataset, we encountered a case where terraform apply failed to execute when a Google Group was deleted. This was caused by the lack of iamMember case, so we added it.

See hashicorp/terraform-provider-google#16288 for more information.

Release Note Template for Downstream PRs (will be copied)

bigquery: added support for `iam_member` to `google_bigquery_dataset.access`
bigquery: fixed a bug when updating a `google_bigquery_dataset` that contained an `iamMember` access rule added out of band with Terraform

@modular-magician
Copy link
Collaborator

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will require approval to run.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels Oct 17, 2023
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 27 insertions(+))
Terraform Beta: Diff ( 2 files changed, 27 insertions(+))
TF Conversion: Diff ( 1 file changed, 11 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_bigquery_dataset (185 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_bigquery_dataset" "primary" {
  access {
    iam_member = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3148
Passed tests 2827
Skipped tests: 317
Affected tests: 4

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccBigQueryDataset_bigqueryDatasetAuthorizedRoutineExample|TestAccBigQueryDataset_bigqueryDatasetAuthorizedDatasetExample|TestAccBigQueryDataset_basic|TestAccBigQueryDataTable_bigtable

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccBigQueryDataset_bigqueryDatasetAuthorizedRoutineExample[Debug log]
TestAccBigQueryDataset_bigqueryDatasetAuthorizedDatasetExample[Debug log]
TestAccBigQueryDataset_basic[Debug log]
TestAccBigQueryDataTable_bigtable[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@syou6162
Copy link
Contributor Author

If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

@rileykarson Could you review this pull request?

@modular-magician modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Oct 20, 2023
@syou6162 syou6162 force-pushed the add_iam_member_for_bigquery_dataset branch from b2ada54 to 7352734 Compare October 20, 2023 02:33
@modular-magician modular-magician removed the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Oct 20, 2023
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 33 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 3 files changed, 33 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 11 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3163
Passed tests 2845
Skipped tests: 317
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccBigQueryDataset_access

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccBigQueryDataset_access[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants