-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add iamMember to access for BigQuery dataset #9288
Add iamMember to access for BigQuery dataset #9288
Conversation
Hello! I am a robot. It looks like you are a: Community Contributor @rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 27 insertions(+)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_bigquery_dataset" "primary" {
access {
iam_member = # value needed
}
}
|
Tests analyticsTotal tests: Action takenFound 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccBigQueryDataset_bigqueryDatasetAuthorizedRoutineExample|TestAccBigQueryDataset_bigqueryDatasetAuthorizedDatasetExample|TestAccBigQueryDataset_basic|TestAccBigQueryDataTable_bigtable |
Rerun these tests in REPLAYING mode to catch issues
|
@rileykarson Could you review this pull request? |
b2ada54
to
7352734
Compare
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 33 insertions(+), 2 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccBigQueryDataset_access |
Rerun these tests in REPLAYING mode to catch issues
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
In google_bigquery_dataset, we encountered a case where terraform apply failed to execute when a Google Group was deleted. This was caused by the lack of
iamMember
case, so we added it.See hashicorp/terraform-provider-google#16288 for more information.
Release Note Template for Downstream PRs (will be copied)