Update documentation and add test case for data cache setting as it is available for postgres now

[nityanavali1]

b/299670813
Now that data cache is supported for PostgreSQL, this PR is for updating documentation and extending test cases for PostgreSQL data cache support

Resource Reference : https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/sql_database_instance#data_cache_enabled

Release Note Template for Downstream PRs (will be copied)

note from rileykarson@: I've made the docs update an enhancement intentionally- since it'll make it clear that new functionality is available through the API, even if there was no code change in Terraform

sql: update `google_sql_database_instance` to reflect that `data_cache_enabled` works for PostgresQL now, in addition to MYSQL

[modular-magician]

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will run automatically.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 39 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 2 files changed, 39 insertions(+), 2 deletions(-))

[modular-magician]

Tests analytics

Total tests: 3145
Passed tests 2809
Skipped tests: 315
Affected tests: 21

Action taken

Found 21 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAlloydbCluster_secondaryClusterDefinedSecondaryConfigButMissingClusterTypeSecondary|TestAccAlloydbCluster_secondaryClusterDefinedSecondaryConfigButClusterTypeIsPrimary|TestAccAlloydbCluster_secondaryClusterUpdate|TestAccAlloydbCluster_secondaryClusterWithNetworkConfigAndAllocatedIPRange|TestAccAlloydbUser_alloydbUserBuiltinExample|TestAccAlloydbCluster_alloydbSecondaryClusterBasicExample|TestAccAlloydbInstance_createPrimaryAndReadPoolInstance|TestAccAlloydbCluster_restore|TestAccAlloydbUser_updateRoles_BuiltIn|TestAccAlloydbInstance_update|TestAccAlloydbCluster_secondaryClusterMissingSecondaryConfig|TestAccAlloydbBackup_createBackupWithMandatoryFields|TestAccAlloydbInstance_createInstanceWithNetworkConfigAndAllocatedIPRange|TestAccAlloydbBackup_usingCMEK|TestAccAlloydbCluster_secondaryClusterWithNetworkConfig|TestAccAlloydbInstance_createInstanceWithMandatoryFields|TestAccAlloydbUser_alloydbUserIamExample|TestAccCloudRunService_cloudRunServiceSqlExample|TestAccDataSourceGoogleServiceAccountAccessToken_basic|TestAccDataSourceGoogleServiceAccountJwt|TestAccSQLDatabaseInstance_sqlPostgresDataCacheConfig

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccAlloydbInstance_createPrimaryAndReadPoolInstance[Debug log]
TestAccAlloydbCluster_restore[Debug log]
TestAccAlloydbInstance_update[Debug log]
TestAccAlloydbBackup_createBackupWithMandatoryFields[Debug log]
TestAccAlloydbInstance_createInstanceWithNetworkConfigAndAllocatedIPRange[Debug log]
TestAccAlloydbBackup_usingCMEK[Debug log]
TestAccAlloydbInstance_createInstanceWithMandatoryFields[Debug log]
TestAccDataSourceGoogleServiceAccountAccessToken_basic[Debug log]
TestAccDataSourceGoogleServiceAccountJwt[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{red}{\textsf{Tests failed when rerunning REPLAYING mode:}}$
TestAccDataSourceGoogleServiceAccountJwt[Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccAlloydbCluster_secondaryClusterDefinedSecondaryConfigButMissingClusterTypeSecondary[Error message] [Debug log]
TestAccAlloydbCluster_secondaryClusterDefinedSecondaryConfigButClusterTypeIsPrimary[Error message] [Debug log]
TestAccAlloydbCluster_secondaryClusterUpdate[Error message] [Debug log]
TestAccAlloydbCluster_secondaryClusterWithNetworkConfigAndAllocatedIPRange[Error message] [Debug log]
TestAccAlloydbUser_alloydbUserBuiltinExample[Error message] [Debug log]
TestAccAlloydbCluster_alloydbSecondaryClusterBasicExample[Error message] [Debug log]
TestAccAlloydbUser_updateRoles_BuiltIn[Error message] [Debug log]
TestAccAlloydbCluster_secondaryClusterMissingSecondaryConfig[Error message] [Debug log]
TestAccAlloydbCluster_secondaryClusterWithNetworkConfig[Error message] [Debug log]
TestAccAlloydbUser_alloydbUserIamExample[Error message] [Debug log]
TestAccCloudRunService_cloudRunServiceSqlExample[Error message] [Debug log]
TestAccSQLDatabaseInstance_sqlPostgresDataCacheConfig[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[rileykarson]

AlloyDB stuff is certainly unrelated, we had to fix something in a way that triggered that error.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 51 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 2 files changed, 51 insertions(+), 2 deletions(-))

[modular-magician]

Tests analytics

Total tests: 3143
Passed tests 2824
Skipped tests: 318
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccSQLDatabaseInstance_sqlPostgresDataCacheConfig

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccSQLDatabaseInstance_sqlPostgresDataCacheConfig[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 51 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 2 files changed, 51 insertions(+), 2 deletions(-))

[modular-magician]

Tests analytics

Total tests: 3196
Passed tests 2869
Skipped tests: 325
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAlloydbCluster_restore|TestAccSQLDatabaseInstance_sqlPostgresDataCacheConfig

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccSQLDatabaseInstance_sqlPostgresDataCacheConfig[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccAlloydbCluster_restore[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[nityanavali1]

All tests are passing except TestAccAlloydbCluster_restore (https://screenshot.googleplex.com/9ibB34RH3TVL7Xi) (failed because of not enough resources available in us-central1). This test is not related to this change. Can I get approval for the merge. As this is needed for GA launch of Postgres with Data cache feature.

[rileykarson]

Note: I cleared cassettes other than TestAccSQLDatabaseInstance_sqlPostgresDataCacheConfig, so that failure cassette won't be merged @ merge time.