Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firestore: Add support for Point-in-time-recovery (PITR) #8907

Conversation

IchordeDionysos
Copy link
Contributor

Adds support for Firestore Point-in-time-recovery (PITR).

Fixes hashicorp/terraform-provider-google#15788

Release Note Template for Downstream PRs (will be copied)

firestore: added `point_in_time_recovery_enablement`, `version_retention_period`, and `earliest_version_time` fields to `google_firestore_database ` resource

@modular-magician
Copy link
Collaborator

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will require approval to run.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Sep 10, 2023
@rileykarson
Copy link
Member

Note: I need to deduplicate w/ #8863

@IchordeDionysos
Copy link
Contributor Author

Ahh okay, I have search for public GitHub issues and did not find anything that's why I filed the issue and started working on it.
But nice to see that there is already a PR and it's already merged.

I don't think this PR is then needed anymore as it does not add anything new...

@rileykarson
Copy link
Member

Closing as this looks redundant after that change!

@rileykarson rileykarson closed this Oct 4, 2023
@IchordeDionysos IchordeDionysos deleted the add-firestore-pitr branch October 4, 2023 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Firestore: Add ability to configure Point-in-time-recovery (PITR)
3 participants