From 53f573e9cd81fb007f6732711096be57edb07ae0 Mon Sep 17 00:00:00 2001 From: Nick Elliot Date: Fri, 8 Sep 2023 15:29:54 -0700 Subject: [PATCH 1/3] docs update --- .../website/docs/guides/version_5_upgrade.html.markdown | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/mmv1/third_party/terraform/website/docs/guides/version_5_upgrade.html.markdown b/mmv1/third_party/terraform/website/docs/guides/version_5_upgrade.html.markdown index f1aed2ca0784..543a70a8e17c 100644 --- a/mmv1/third_party/terraform/website/docs/guides/version_5_upgrade.html.markdown +++ b/mmv1/third_party/terraform/website/docs/guides/version_5_upgrade.html.markdown @@ -118,8 +118,16 @@ The new annotations model is similar to the new labels model and will be applied There are now two annotation-related fields with the new model, the `annotations` and the output-only `effective_annotations` fields. +### Provider default values shown at plan-time + +`project`, `region`, and `zone` fields will now display their values during plan-time instead of defaulting to the unknown `(known after apply)` value normally displayed for `computed` fields. These values will be taken from either the Terraform resource config file, provider config, or local environment variables, depending on which variables are supplied by the user, matching the existing per-resource functionality for what default values are used in execution of a Terraform plan. + ## Datasources +### Datasources now error universally on 404 + +All data sources have been updated to return an error when a target resource URI can not be reached. Previously this was inconsistent between different datasources in whether an empty value was returned to Terraform state upon 404 or if an error was returned, but this has been standardized. Any plans that reference datasources which no longer exist (or do not exist yet) will need to be revised to have these datasources removed from configuration files. + ## Datasource: `google_product_datasource` ### Datasource-level change example header From 6e6bb4c11e980942c419e7aa9f04fee27fa4fe34 Mon Sep 17 00:00:00 2001 From: Nick Elliot Date: Mon, 11 Sep 2023 09:43:31 -0700 Subject: [PATCH 2/3] Update version_5_upgrade.html.markdown --- .../website/docs/guides/version_5_upgrade.html.markdown | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mmv1/third_party/terraform/website/docs/guides/version_5_upgrade.html.markdown b/mmv1/third_party/terraform/website/docs/guides/version_5_upgrade.html.markdown index 543a70a8e17c..b61bdec7e51f 100644 --- a/mmv1/third_party/terraform/website/docs/guides/version_5_upgrade.html.markdown +++ b/mmv1/third_party/terraform/website/docs/guides/version_5_upgrade.html.markdown @@ -120,7 +120,7 @@ There are now two annotation-related fields with the new model, the `annotations ### Provider default values shown at plan-time -`project`, `region`, and `zone` fields will now display their values during plan-time instead of defaulting to the unknown `(known after apply)` value normally displayed for `computed` fields. These values will be taken from either the Terraform resource config file, provider config, or local environment variables, depending on which variables are supplied by the user, matching the existing per-resource functionality for what default values are used in execution of a Terraform plan. +`project`, `region`, and `zone` fields will now display their values during plan-time instead of the placeholder `(known after apply)` value normally displayed for fields without fixed default values. These values will be taken from either the Terraform resource config file, provider config, or local environment variables, depending on which variables are supplied by the user, matching the existing per-resource functionality for what default values are used in execution of a Terraform plan. ## Datasources @@ -445,4 +445,4 @@ resource "google_project_iam_binding" "gcs-bucket-writer" { ### `Create` endpoint is used to create the resource -`google_service_networking_connection` now uses the Create endpoint instead of the Patch endpoint during the creation step. Previously, Patch was used as a workaround for an issue that has since been resolved. \ No newline at end of file +`google_service_networking_connection` now uses the Create endpoint instead of the Patch endpoint during the creation step. Previously, Patch was used as a workaround for an issue that has since been resolved. From ccba719395ee627c2767d86922f104d7318775b4 Mon Sep 17 00:00:00 2001 From: Nick Elliot Date: Mon, 11 Sep 2023 10:02:35 -0700 Subject: [PATCH 3/3] Update version_5_upgrade.html.markdown --- .../website/docs/guides/version_5_upgrade.html.markdown | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mmv1/third_party/terraform/website/docs/guides/version_5_upgrade.html.markdown b/mmv1/third_party/terraform/website/docs/guides/version_5_upgrade.html.markdown index b61bdec7e51f..91ed84e2e849 100644 --- a/mmv1/third_party/terraform/website/docs/guides/version_5_upgrade.html.markdown +++ b/mmv1/third_party/terraform/website/docs/guides/version_5_upgrade.html.markdown @@ -120,7 +120,7 @@ There are now two annotation-related fields with the new model, the `annotations ### Provider default values shown at plan-time -`project`, `region`, and `zone` fields will now display their values during plan-time instead of the placeholder `(known after apply)` value normally displayed for fields without fixed default values. These values will be taken from either the Terraform resource config file, provider config, or local environment variables, depending on which variables are supplied by the user, matching the existing per-resource functionality for what default values are used in execution of a Terraform plan. +`project`, `region`, and `zone` fields will now display their values during plan-time instead of the placeholder `(known after apply)` value normally displayed for fields without fixed Terraform default values. These values will be taken from either the Terraform resource config file, provider config, or local environment variables, depending on which variables are supplied by the user, matching the existing per-resource functionality for what default values are used in execution of a Terraform plan. ## Datasources