-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix TF: unskip test TestAccDataprocVirtualCluster_basic #12530
Fix TF: unskip test TestAccDataprocVirtualCluster_basic #12530
Conversation
devanshikhatsuriya
commented
Dec 10, 2024
•
edited
Loading
edited
- Unskip failing test fixed in Fix TF: Failing test(s): TestAccDataprocVirtualCluster_basic #12454, tested manually
- Related to Failing test(s): TestAccDataprocVirtualCluster_basic hashicorp/terraform-provider-google#19076
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @melinath , a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the changes in this PR were already in #12454 - except removing SkipIfVcr (which is actually missing here - possibly not pushed?)
@modular-magician reassign-reviewer melinath |
Tests analyticsTotal tests: 66 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
Tests analyticsTotal tests: 66 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|