Add tags field to Filestore Instances for TagsR2401

[aniket-gupta]

Add tags field to instance resource to allow setting tags on instance resources at creation time.
Part of b/364841739

filestore: added `tags` field to `filstore_instance` to allow setting tags for instances at creation time

The contents of this code are entirely owned by Google LLC in accordance with the agreement between Google LLC and the third party submitting this code into Google's open source repository

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 88 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 4 files changed, 88 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 17 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_filestore_instance (21 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_filestore_instance" "primary" {
  tags = # value needed
}

[modular-magician]

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• filestore

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

• TestAccFilestoreInstance_tags
  🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

[SamanthaMathews]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 88 insertions(+), 3 deletions(-)) google-beta provider: Diff ( 4 files changed, 88 insertions(+), 3 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 17 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_filestore_instance (21 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_filestore_instance" "primary" {
  tags = # value needed
}

The acceptance test is added in the file mmv1/third_party/terraform/services/filestore/resource_filestore_instance_test.go

resource "google_filestore_instance" "instance" {
  name = "tf-instance-%s"
  zone = "us-central1-b"
  tier = "BASIC_HDD"
  file_shares {
    capacity_gb = 1024
    name        = "share1"
  }
  networks {
    network           = "default"
    modes             = ["MODE_IPV4"]
    reserved_ip_range = "172.19.31.8/29"
  }
tags = {`, name)

	l := ""
	for key, value := range tags {
		l += fmt.Sprintf("%q = %q\n", key, value)
	}

	l += fmt.Sprintf("}\n}")
	return r + l
}

Please find the acceptance test screenshot https://screenshot.googleplex.com/C6M97rNFj37WyfP