From e688b0dafb002ae71e9dd57a0e1e8d3f7331e194 Mon Sep 17 00:00:00 2001 From: Nick Elliot Date: Thu, 21 Sep 2023 16:35:23 -0700 Subject: [PATCH] docs update --- .../guides/version_5_upgrade.html.markdown | 29 ++++++++++++++++++- 1 file changed, 28 insertions(+), 1 deletion(-) diff --git a/mmv1/third_party/terraform/website/docs/guides/version_5_upgrade.html.markdown b/mmv1/third_party/terraform/website/docs/guides/version_5_upgrade.html.markdown index 6cad0bd57bbf..4d049b1ae9c8 100644 --- a/mmv1/third_party/terraform/website/docs/guides/version_5_upgrade.html.markdown +++ b/mmv1/third_party/terraform/website/docs/guides/version_5_upgrade.html.markdown @@ -143,6 +143,10 @@ This will only affect users whose configuration contains resource blocks that ha `project`, `region`, and `zone` fields will now display their values during plan-time instead of the placeholder `(known after apply)` value normally displayed for fields without fixed Terraform default values. These values will be taken from either the Terraform resource config file, provider config, or local environment variables, depending on which variables are supplied by the user, matching the existing per-resource functionality for what default values are used in execution of a Terraform plan. +### Resource import formats have improved validation + +Throughout the provider there were many resources which erroneously gave false positives to poorly formatted import input if a subset of the provided input was valid to their configured import formats. All GCP resource IDs supplied to "terraform import" must match the documentation specified import formats exactly. + ## Datasources ### Datasources now error universally on 404 @@ -347,7 +351,6 @@ it will use the default value from the API which is `FALSE`. If you want to enable endpoint independent mapping, then explicity set the value of `enable_endpoint_independent_mapping` field to `TRUE`. - ## Resource: `google_firebase_project_location` ### `google_firebase_project_location` is now removed @@ -570,3 +573,27 @@ Use the `google_identity_platform_config` resource instead. It contains a more c ### `reconcile_connections` now defaults from API `reconcile_connections` previously defaults to true. Now it will default from the API. + +## Resource: `google_dataflow_flex_template_job` + +### Fields that are a part of the [environment block](https://cloud.google.com/dataflow/docs/reference/rest/v1b3/projects.locations.flexTemplates/launch#FlexTemplateRuntimeEnvironment) will be overriden to be sent via their fields even when supplied via parameters. + +Several fields within the `flex_template_job` resource can be supplied as part of the `parameters{}` block rather than configured directly as updates to their corresponding fields, which had Terraform support added in version 4.66. To resolve a conflict resulting from both values being included within Terraform state, all supplied key-value pair parameters with corresponding fields will be overridden to be sent to their direct field endpoint rather than included as part of `parameters{}` in the post request. + +Additionally, due to the API returning these fields to the user they will now be considered computed and users will see values twice within their state if they wish to continue supplying these fields' values via parameters. + +## Resource: `google_compute_node_group` + +### Node groups are now mutable + +Due to limitations in previous field configurations, the only field that could be updated previously was `node_template`. It is now possible to adjust the `autoscaling_policy` without recreating the group, nor will any adjustment to the `size` of the nodepool prompt resource recration. + +### `size` is now an output only field. + +`size` previously served as an alias for initial_size on resource creation and would force recreation if the size of the node_group ever adjusted due to either direct user update or auto-scaling adjustment outside of Terraform. + +It will now mirror its API functionality and serve as an output only field to show how many nodes currently exist within the resource. + +### One of `initial_size` or `autoscaling_policy{}` must be configured on resource creation. + +These fields will supply the base node-count for a node group and one of them will be required for successful resource creation. Both will be freely updateable or removable on future state changes that do not require recreation.