From a3ee765e54c58a3d58d62f5a7296c7bae4e06c03 Mon Sep 17 00:00:00 2001 From: Cameron Thornton Date: Fri, 22 Sep 2023 22:47:55 -0500 Subject: [PATCH] google_monitoring_dashboard --- .../docs/guides/version_5_upgrade.html.markdown | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/mmv1/third_party/terraform/website/docs/guides/version_5_upgrade.html.markdown b/mmv1/third_party/terraform/website/docs/guides/version_5_upgrade.html.markdown index de0d5ada50d7..c8e44941f263 100644 --- a/mmv1/third_party/terraform/website/docs/guides/version_5_upgrade.html.markdown +++ b/mmv1/third_party/terraform/website/docs/guides/version_5_upgrade.html.markdown @@ -513,12 +513,24 @@ resource "google_firestore_database" "default" { ### `deletion_policy` now defaults to `DELETE` Previously, `google_firebase_web_app` deletions default to `ABANDON`, which means to only stop tracking the WebApp in Terraform. The actual app is not deleted from the Firebase project. If you are relying on this behavior, set `deletion_policy` to `ABANDON` explicitly in the new version. + + ## Resource: `google_compute_autoscaler` (beta) ### `metric.filter` now defaults to `resource.type = gce_instance` Previously, `metric.filter` doesn't have the defult value and causes a UI error. + +## Resource: `google_monitoring_dashboard` + +### `dashboard_json` suppresses removal diffs more aggressively + +To prevent permanent diffs from default values, Terraform will now attempt to suppress diffs where the value is returned in the JSON +string but doesn't exist in the configuration. Consequently, legitmate remove-only diffs will also be suppressed. +For Terraform to detect the diff, JSON key removals must also be accompanied by a non-removal change (trivial or not). + + ## Resource: `google_monitoring_metric_descriptor` ### Changing `labels` now triggers replacement